Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): add validation for eval import/export #3018

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Nov 22, 2023

Description

  1. add validation for import and export
  2. tune request body

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cdae936) 91.40% compared to head (a70a019) 82.82%.
Report is 7 commits behind head on main.

Files Patch % Lines
...ava/ai/starwhale/mlops/api/FineTuneController.java 0.00% 2 Missing ⚠️
.../starwhale/mlops/domain/ft/FineTuneAppService.java 92.85% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3018      +/-   ##
============================================
- Coverage     91.40%   82.82%   -8.58%     
- Complexity        0     3158    +3158     
============================================
  Files           129      555     +426     
  Lines         15032    30421   +15389     
  Branches         61     1777    +1716     
============================================
+ Hits          13740    25197   +11457     
- Misses         1290     4414    +3124     
- Partials          2      810     +808     
Flag Coverage Δ
console ?
controller 73.92% <86.66%> (?)
standalone 91.91% <100.00%> (+0.23%) ⬆️
unittests 91.91% <100.00%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goldenxinxing goldenxinxing force-pushed the chore/tune-request-type-for-ft-import branch from 2967406 to c4ba0f6 Compare November 23, 2023 01:56
@goldenxinxing goldenxinxing marked this pull request as draft November 23, 2023 02:53
@goldenxinxing goldenxinxing force-pushed the chore/tune-request-type-for-ft-import branch from a30602a to 7e36239 Compare November 23, 2023 03:41
@goldenxinxing goldenxinxing marked this pull request as ready for review November 23, 2023 03:42
@goldenxinxing goldenxinxing changed the title chore(controller): tune ft eval import/export param to request body fix(controller): add validation for eval import/export Nov 23, 2023
@goldenxinxing goldenxinxing added the hotfix 🔥 hotfix bug label Nov 23, 2023
@goldenxinxing goldenxinxing force-pushed the chore/tune-request-type-for-ft-import branch from 64dbd09 to e3feecb Compare November 23, 2023 06:03
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 67d6fee into star-whale:main Nov 24, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix 🔥 hotfix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants