Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(SDK): tune finetune decorator for Dataset type arguments #3007

Merged

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ffa661) 82.50% compared to head (2796498) 92.06%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3007      +/-   ##
============================================
+ Coverage     82.50%   92.06%   +9.55%     
============================================
  Files           563      124     -439     
  Lines         30365    14964   -15401     
  Branches       1826        0    -1826     
============================================
- Hits          25053    13776   -11277     
+ Misses         4502     1188    -3314     
+ Partials        810        0     -810     
Flag Coverage Δ
console ?
controller ?
standalone 92.06% <100.00%> (+0.06%) ⬆️
unittests 92.06% <100.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 8b19f10 into star-whale:main Nov 22, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ❤️ New feature or request sdk 🐶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants