Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: add helloworld example - fast, sufficient and light #3000

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Nov 20, 2023

Description

remove pytorch heavy dependency.

  • server run:
    image
  • standalone run:
    image
  • model build:
    image
  • dataset build:
    image

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07e6c5b) 82.45% compared to head (2fdc38b) 92.04%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3000      +/-   ##
============================================
+ Coverage     82.45%   92.04%   +9.59%     
============================================
  Files           563      124     -439     
  Lines         30351    14962   -15389     
  Branches       1826        0    -1826     
============================================
- Hits          25026    13772   -11254     
+ Misses         4521     1190    -3331     
+ Partials        804        0     -804     
Flag Coverage Δ
console ?
controller ?
standalone 92.04% <ø> (+0.10%) ⬆️
unittests 92.04% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianweidut tianweidut changed the title example: add helloworld mnist example example: add helloworld example: fast, sufficient and light Nov 21, 2023
@tianweidut tianweidut marked this pull request as ready for review November 21, 2023 03:25
@tianweidut tianweidut self-assigned this Nov 21, 2023
@tianweidut tianweidut changed the title example: add helloworld example: fast, sufficient and light example: add helloworld example - fast, sufficient and light Nov 21, 2023
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 857cff0 into star-whale:main Nov 21, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants