Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): add env for gradio root when web service uses proxy #2996

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Related to:

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d2db61) 82.51% compared to head (c0bb2e5) 73.29%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2996      +/-   ##
============================================
- Coverage     82.51%   73.29%   -9.22%     
- Complexity     3111     3119       +8     
============================================
  Files           563      436     -127     
  Lines         30353    15187   -15166     
  Branches       1826     1765      -61     
============================================
- Hits          25045    11132   -13913     
+ Misses         4503     3247    -1256     
- Partials        805      808       +3     
Flag Coverage Δ
console ?
controller 73.29% <100.00%> (+0.02%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit cd3faf1 into star-whale:main Nov 20, 2023
17 checks passed
@jialeicui jialeicui deleted the add-root-for-gradio branch November 20, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants