Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): rename for finetune info #2995

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Nov 17, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the chore 🛎️ some tiny change label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9282b1) 82.45% compared to head (f248d2a) 82.55%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2995      +/-   ##
============================================
+ Coverage     82.45%   82.55%   +0.10%     
- Complexity     3110     3112       +2     
============================================
  Files           563      560       -3     
  Lines         30345    30149     -196     
  Branches       1825     1765      -60     
============================================
- Hits          25020    24891     -129     
+ Misses         4522     4456      -66     
+ Partials        803      802       -1     
Flag Coverage Δ
console ?
controller 73.26% <100.00%> (+0.01%) ⬆️
standalone 91.99% <100.00%> (+0.05%) ⬆️
unittests 91.99% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goldenxinxing goldenxinxing changed the title chore(controller): add type for job vo chore(controller): rename for finetune info Nov 20, 2023
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 2e624a3 into star-whale:main Nov 20, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants