Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): new impl of model serving #2978

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Nov 14, 2023

Description

TODO:

  • support custom serving without online eval support (e.g. use gradio as input or output)
  • support online eval in console
  • support other inference types components
chat.mp4

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft November 14, 2023 10:24
@jialeicui jialeicui changed the title refactor(client): drop supporting of gradio enhance(client): new impl of model serving Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (ee53554) 82.96% compared to head (4d3c7ae) 91.70%.
Report is 6 commits behind head on main.

Files Patch % Lines
client/starwhale/api/_impl/service/service.py 72.05% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2978      +/-   ##
============================================
+ Coverage     82.96%   91.70%   +8.74%     
============================================
  Files           557      127     -430     
  Lines         30354    15159   -15195     
  Branches       1827       61    -1766     
============================================
- Hits          25183    13902   -11281     
+ Misses         4366     1255    -3111     
+ Partials        805        2     -803     
Flag Coverage Δ
console 72.09% <ø> (ø)
controller ?
standalone 91.99% <76.82%> (-0.07%) ⬇️
unittests 91.70% <76.82%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jialeicui jialeicui force-pushed the api-decorator branch 2 times, most recently from ad751ab to 89f9a00 Compare November 16, 2023 02:42
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 62d41f7 into star-whale:main Nov 17, 2023
38 checks passed
@jialeicui jialeicui deleted the api-decorator branch November 17, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants