Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): support login with browser #2916

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Oct 27, 2023

Description

login.mp4

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added enhancement ❤️ New feature or request client 🌈 labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2916 (661c066) into main (87994fc) will increase coverage by 8.51%.
Report is 5 commits behind head on main.
The diff coverage is 11.90%.

@@             Coverage Diff              @@
##               main    #2916      +/-   ##
============================================
+ Coverage     83.22%   91.74%   +8.51%     
============================================
  Files           541      125     -416     
  Lines         29318    15039   -14279     
  Branches       1687       59    -1628     
============================================
- Hits          24399    13797   -10602     
+ Misses         4139     1240    -2899     
+ Partials        780        2     -778     
Flag Coverage Δ
console 72.85% <ø> (?)
controller ?
standalone 92.00% <11.90%> (-0.16%) ⬇️
unittests 91.74% <11.90%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/starwhale/core/instance/view.py 43.60% <11.90%> (-14.64%) ⬇️

... and 427 files with indirect coverage changes

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit af283ad into star-whale:main Oct 30, 2023
37 of 38 checks passed
@jialeicui jialeicui deleted the cli-token branch October 30, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client 🌈 enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants