Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): show the latest alias #2545

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

jialeicui
Copy link
Contributor

Description

cc @lijing-susan

2023-07-21_11-22

2023-07-21_11-22_1

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #2545 (d37b006) into main (6089e66) will decrease coverage by 8.13%.
The diff coverage is 46.15%.

❗ Current head d37b006 differs from pull request most recent head f7b5bf8. Consider uploading reports for the commit f7b5bf8 to get more accurate results

@@             Coverage Diff              @@
##               main    #2545      +/-   ##
============================================
- Coverage     82.75%   74.63%   -8.13%     
+ Complexity     2652     2650       -2     
============================================
  Files           451      349     -102     
  Lines         24530    12665   -11865     
  Branches       1482     1487       +5     
============================================
- Hits          20299     9452   -10847     
+ Misses         3575     2551    -1024     
- Partials        656      662       +6     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller 74.59% <46.15%> (-0.07%) ⬇️
standalone ?
unittests 79.76% <ø> (-11.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...whale/mlops/api/protocol/model/ModelVersionVo.java 0.00% <0.00%> (ø)
.../starwhale/mlops/common/VersionAliasConverter.java 83.33% <ø> (-3.34%) ⬇️
...omain/model/converter/ModelVersionVoConverter.java 80.95% <0.00%> (-4.05%) ⬇️
...starwhale/mlops/domain/dataset/DatasetService.java 79.28% <50.00%> (-0.29%) ⬇️
...n/dataset/converter/DatasetVersionVoConverter.java 81.25% <50.00%> (-6.25%) ⬇️
...starwhale/mlops/domain/runtime/RuntimeService.java 77.74% <50.00%> (-0.22%) ⬇️
...ain/runtime/converter/RuntimeVersionConverter.java 94.73% <50.00%> (-5.27%) ⬇️
.../ai/starwhale/mlops/domain/model/ModelService.java 79.86% <66.66%> (-0.14%) ⬇️

... and 104 files with indirect coverage changes

Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit bde12bb into star-whale:main Jul 24, 2023
17 checks passed
@jialeicui jialeicui deleted the latest-ver branch July 24, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants