Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): page not working #2540

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Jul 20, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #2540 (08fdb2c) into main (ae41e33) will decrease coverage by 8.06%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##               main    #2540      +/-   ##
============================================
- Coverage     82.79%   74.73%   -8.06%     
- Complexity     2654     2658       +4     
============================================
  Files           451      348     -103     
  Lines         24530    12582   -11948     
  Branches       1482     1469      -13     
============================================
- Hits          20309     9403   -10906     
+ Misses         3567     2524    -1043     
- Partials        654      655       +1     
Flag Coverage Δ
console ?
controller 74.73% <90.00%> (+0.04%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/ai/starwhale/mlops/domain/job/JobDao.java 22.36% <50.00%> (+2.63%) ⬆️
...starwhale/mlops/domain/dataset/DatasetService.java 79.56% <100.00%> (ø)
...ale/mlops/domain/evaluation/EvaluationService.java 75.75% <100.00%> (ø)
...java/ai/starwhale/mlops/domain/job/JobService.java 80.66% <100.00%> (ø)
.../ai/starwhale/mlops/domain/model/ModelService.java 80.00% <100.00%> (ø)
...starwhale/mlops/domain/runtime/RuntimeService.java 77.96% <100.00%> (ø)
...va/ai/starwhale/mlops/domain/task/TaskService.java 51.35% <100.00%> (-1.29%) ⬇️

... and 107 files with indirect coverage changes

anda-ren
anda-ren previously approved these changes Jul 21, 2023
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
btw, add some UT?

jialeicui
jialeicui previously approved these changes Jul 21, 2023
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing dismissed stale reviews from jialeicui and anda-ren via d3e54b1 July 21, 2023 09:06
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit a7ede5b into star-whale:main Jul 25, 2023
17 checks passed
@goldenxinxing goldenxinxing deleted the fix/page_not_effect branch August 25, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants