Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): the job is deleted even if exception occurs when collecting logs #2536

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix(controller): the job is deleted even if exception occurs when collecting logs #2536

merged 1 commit into from
Jul 20, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added bug 🐛 Something isn't working controller 🏘️ labels Jul 20, 2023
goldenxinxing
goldenxinxing approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 6d2db82 into star-whale:main Jul 20, 2023
13 checks passed
@jialeicui jialeicui deleted the fix-cancel branch July 20, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldenxinxing goldenxinxing goldenxinxing approved these changes

@anda-ren anda-ren Awaiting requested review from anda-ren

Assignees
No one assigned
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jialeicui @goldenxinxing