Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example(LLM): support llama2 model evaluation #2528

Merged
merged 3 commits into from
Jul 20, 2023
Merged

example(LLM): support llama2 model evaluation #2528

merged 3 commits into from
Jul 20, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Jul 19, 2023 •
edited
Loading

Description

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut self-assigned this Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Merging #2528 (efaaef2) into main (7c7ff4f) will increase coverage by 8.62%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2528      +/-   ##
============================================
+ Coverage     82.75%   91.38%   +8.62%     
============================================
  Files           451      102     -349     
  Lines         24524    11863   -12661     
  Branches       1481        0    -1481     
============================================
- Hits          20296    10841    -9455     
+ Misses         3572     1022    -2550     
+ Partials        656        0     -656
Flag Coverage Δ
console ?
controller ?
standalone 91.38% <ø> (-0.03%) ⬇️
unittests 91.38% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 350 files with indirect coverage changes

@tianweidut tianweidut marked this pull request as draft July 19, 2023 11:09
@tianweidut tianweidut marked this pull request as ready for review July 19, 2023 11:19
goldenxinxing
goldenxinxing approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit e01cc8d into star-whale:main Jul 20, 2023
38 checks passed
@tianweidut tianweidut deleted the example/llama2 branch September 5, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldenxinxing goldenxinxing goldenxinxing approved these changes

@jialeicui jialeicui Awaiting requested review from jialeicui

@anda-ren anda-ren Awaiting requested review from anda-ren

Assignees

@tianweidut tianweidut

Labels
example 🚕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianweidut @goldenxinxing