Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(client): fix builtin runtime run error #2462

Merged
merged 1 commit into from
Jul 6, 2023
Merged

bug(client): fix builtin runtime run error #2462

merged 1 commit into from
Jul 6, 2023

Conversation

tianweidut
Copy link
Member

Description

image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added the e2e label Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Merging #2462 (c4aa6f1) into main (fffd343) will increase coverage by 7.70%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2462      +/-   ##
============================================
+ Coverage     83.49%   91.20%   +7.70%     
============================================
  Files           435      100     -335     
  Lines         23749    11688   -12061     
  Branches       1399        0    -1399     
============================================
- Hits          19830    10660    -9170     
+ Misses         3281     1028    -2253     
+ Partials        638        0     -638
Flag Coverage Δ
controller ?
standalone 91.20% <ø> (+<0.01%) ⬆️
unittests 91.20% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/runtime/process.py 100.00% <ø> (ø)

... and 337 files with indirect coverage changes

@tianweidut tianweidut mentioned this pull request Jul 6, 2023
Merged
4 tasks
@goldenxinxing goldenxinxing reopened this Jul 6, 2023
@tianweidut tianweidut force-pushed the fix/builtin-runtime branch 3 times, most recently from 67c416c to eb53273 Compare July 6, 2023 06:04
goldenxinxing
goldenxinxing approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit f033f77 into star-whale:main Jul 6, 2023
@tianweidut tianweidut deleted the fix/builtin-runtime branch September 5, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldenxinxing goldenxinxing goldenxinxing approved these changes

Assignees

@tianweidut tianweidut

@goldenxinxing goldenxinxing

Labels
bug 🐛 Something isn't working client 🌈 e2e runtime🐌
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianweidut @goldenxinxing