Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): resource in private project can not be shared #2447

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #2447 (b342e8c) into main (31aac4a) will decrease coverage by 7.38%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2447      +/-   ##
============================================
- Coverage     83.45%   76.08%   -7.38%     
- Complexity     2590     2594       +4     
============================================
  Files           436      335     -101     
  Lines         23809    12083   -11726     
  Branches       1409     1398      -11     
============================================
- Hits          19870     9193   -10677     
+ Misses         3302     2253    -1049     
  Partials        637      637              
Flag Coverage Δ
console ?
controller 76.08% <100.00%> (+0.02%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...starwhale/mlops/domain/dataset/DatasetService.java 87.11% <100.00%> (+0.16%) ⬆️
.../ai/starwhale/mlops/domain/model/ModelService.java 79.63% <100.00%> (+0.13%) ⬆️
...starwhale/mlops/domain/runtime/RuntimeService.java 78.02% <100.00%> (+0.18%) ⬆️

... and 102 files with indirect coverage changes

@jialeicui jialeicui requested a review from anda-ren July 4, 2023 08:28
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 06c1092 into star-whale:main Jul 5, 2023
@jialeicui jialeicui deleted the rc-share branch July 5, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants