Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): grid table search with IN by multi status, fix view switch problems #2425

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Jun 29, 2023

Description

image

  • Resolve the issue of project grid view configuration not resetting when switching.
  • Add a map cache to store the current view of multiple projects.
  • Fix the bug where the query component content does not reset.
  • Modify the widget component by removing the register logic to prevent hot reload failures.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz changed the title feat(console): grid table search with IN by multi status wip feat(console): grid table search with IN by multi status Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2425 (f2b8612) into main (0ac8356) will decrease coverage by 3.65%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2425      +/-   ##
============================================
- Coverage     83.40%   79.76%   -3.65%     
============================================
  Files           434        1     -433     
  Lines         23696       84   -23612     
  Branches       1405       14    -1391     
============================================
- Hits          19763       67   -19696     
+ Misses         3295       17    -3278     
+ Partials        638        0     -638     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone ?
unittests 79.76% <ø> (-11.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 433 files with indirect coverage changes

@waynelwz waynelwz changed the title wip feat(console): grid table search with IN by multi status feat(console): grid table search with IN by multi status Jun 29, 2023
@waynelwz waynelwz requested a review from jialeicui June 29, 2023 07:56
@waynelwz waynelwz changed the title feat(console): grid table search with IN by multi status wip feat(console): grid table search with IN by multi status Jun 29, 2023
@waynelwz waynelwz changed the title wip feat(console): grid table search with IN by multi status feat(console): grid table search with IN by multi status, fix view switch problems Jun 30, 2023
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit c0c89d6 into star-whale:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants