Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): runtime can not upload when user is not system admin #2412

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jun 27, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #2412 (34d9e1e) into main (b257518) will decrease coverage by 7.49%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2412      +/-   ##
============================================
- Coverage     83.35%   75.87%   -7.49%     
+ Complexity     2554     2553       -1     
============================================
  Files           434      334     -100     
  Lines         23638    11962   -11676     
  Branches       1399     1381      -18     
============================================
- Hits          19704     9076   -10628     
+ Misses         3303     2256    -1047     
+ Partials        631      630       -1     
Flag Coverage Δ
console ?
controller 75.87% <100.00%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../starwhale/mlops/common/proxy/WebServerInTask.java 100.00% <100.00%> (+15.00%) ⬆️
...n/security/ProjectNameExtractorDataStoreMixed.java 75.00% <100.00%> (+0.42%) ⬆️

... and 101 files with indirect coverage changes

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 133fbb8 into star-whale:main Jun 28, 2023
@jialeicui jialeicui deleted the fix-proxy branch June 28, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants