Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(model): model copy retries and add read limit for LengthAbleInputStream #2407

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Jun 26, 2023

  1. add read limit for LengthAbleInputStream
  2. add http request retries for model copy

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

  1. add read limit for LengthAbleInputStream
  2. add http request retries for model copy
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #2407 (1dfd5f7) into main (9377db3) will decrease coverage by 0.04%.
The diff coverage is 68.33%.

@@             Coverage Diff              @@
##               main    #2407      +/-   ##
============================================
- Coverage     83.71%   83.67%   -0.04%     
- Complexity     2533     2541       +8     
============================================
  Files           432      431       -1     
  Lines         23452    23399      -53     
  Branches       1371     1359      -12     
============================================
- Hits          19632    19580      -52     
+ Misses         3197     3192       -5     
- Partials        623      627       +4     
Flag Coverage Δ
console ?
controller 76.44% <75.00%> (+0.04%) ⬆️
standalone 91.06% <50.00%> (-0.14%) ⬇️
unittests 91.06% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/model/copy.py 91.46% <50.00%> (-1.43%) ⬇️
...starwhale/mlops/storage/LengthAbleInputStream.java 73.46% <73.17%> (+35.37%) ⬆️
.../ai/starwhale/mlops/domain/model/ModelService.java 79.26% <100.00%> (+0.39%) ⬆️

... and 7 files with indirect coverage changes

@tianweidut tianweidut changed the title bugfix:... bugfix(model): model copy retries and add read limit for LengthAbleInputStream Jun 26, 2023
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit f569731 into star-whale:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants