Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(client): model copy compression and fileExisted issue #2402

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Jun 26, 2023

  1. improve compression judgement logics
  2. fix a boundary error when dealing with compressed chunks
  3. fix FileExistsError when copy model with force

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

  1. improve compression judgement logics
  2. fix a boundary error when dealing with compressed chunks
  3. fix FileExistsError when copy model with force
@xuchuan xuchuan requested a review from tianweidut June 26, 2023 04:33
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #2402 (8201185) into main (fe1f3e3) will increase coverage by 7.47%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2402      +/-   ##
============================================
+ Coverage     83.70%   91.18%   +7.47%     
============================================
  Files           432       99     -333     
  Lines         23448    11570   -11878     
  Branches       1371        0    -1371     
============================================
- Hits          19627    10550    -9077     
+ Misses         3197     1020    -2177     
+ Partials        624        0     -624     
Flag Coverage Δ
console ?
controller ?
standalone 91.18% <100.00%> (-0.02%) ⬇️
unittests 91.18% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/model/copy.py 92.88% <100.00%> (+0.03%) ⬆️

... and 334 files with indirect coverage changes

@tianweidut tianweidut changed the title bugfix(client): ... bugfix(client): model copy compression and fileExisted issue Jun 26, 2023
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 265eac1 into star-whale:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants