Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add environment variables for model copy timeout and retries #2395

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Jun 25, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #2395 (ca744e6) into main (68239dc) will increase coverage by 7.49%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2395      +/-   ##
============================================
+ Coverage     83.70%   91.20%   +7.49%     
============================================
  Files           432       99     -333     
  Lines         23425    11569   -11856     
  Branches       1366        0    -1366     
============================================
- Hits          19607    10551    -9056     
+ Misses         3194     1018    -2176     
+ Partials        624        0     -624     
Flag Coverage Δ
console ?
controller ?
standalone 91.20% <100.00%> (+0.01%) ⬆️
unittests 91.20% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/model/copy.py 92.87% <100.00%> (ø)

... and 334 files with indirect coverage changes

@tianweidut tianweidut enabled auto-merge (squash) June 25, 2023 08:21
@tianweidut tianweidut disabled auto-merge June 25, 2023 08:25
@tianweidut tianweidut merged commit 53a0e77 into star-whale:main Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants