Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support job pin/unpin #2386

Merged
merged 15 commits into from
Jun 26, 2023
Merged

Conversation

waynelwz
Copy link
Contributor

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz requested a review from jialeicui June 21, 2023 10:11
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #2386 (e70c03e) into main (148b4b5) will decrease coverage by 7.32%.
The diff coverage is 61.53%.

@@             Coverage Diff              @@
##               main    #2386      +/-   ##
============================================
- Coverage     83.72%   76.40%   -7.32%     
- Complexity     2530     2532       +2     
============================================
  Files           432      333      -99     
  Lines         23425    11880   -11545     
  Branches       1366     1371       +5     
============================================
- Hits          19612     9077   -10535     
+ Misses         3191     2179    -1012     
- Partials        622      624       +2     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller 76.38% <61.53%> (-0.02%) ⬇️
standalone ?
unittests 79.76% <ø> (-11.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/ai/starwhale/mlops/api/protocol/job/JobVo.java 20.00% <ø> (ø)
...ain/java/ai/starwhale/mlops/domain/job/JobDao.java 19.73% <0.00%> (-1.10%) ⬇️
...ain/java/ai/starwhale/mlops/domain/job/bo/Job.java 50.00% <ø> (ø)
...va/ai/starwhale/mlops/domain/job/po/JobEntity.java 100.00% <ø> (ø)
...whale/mlops/domain/job/converter/JobConverter.java 62.62% <66.66%> (+0.12%) ⬆️
...ain/java/ai/starwhale/mlops/api/JobController.java 96.62% <100.00%> (+0.15%) ⬆️
...java/ai/starwhale/mlops/domain/job/JobService.java 80.00% <100.00%> (+0.09%) ⬆️
...ale/mlops/domain/job/converter/JobBoConverter.java 91.50% <100.00%> (+0.08%) ⬆️

... and 105 files with indirect coverage changes

commit ff0dfa4
Author: waynelwz <wytheme.go@gmail.com>
Date:   Fri Jun 16 15:43:53 2023 +0800

    update: fix checkstyle

commit d4c9cfc
Author: waynelwz <wytheme.go@gmail.com>
Date:   Fri Jun 16 15:28:02 2023 +0800

    update: format

commit e51a191
Author: waynelwz <wytheme.go@gmail.com>
Date:   Fri Jun 16 15:20:26 2023 +0800

    update: fix checkstyle

commit e388540
Author: waynelwz <wytheme.go@gmail.com>
Date:   Fri Jun 16 15:00:27 2023 +0800

    feat: support job pin/unpin

commit a7b137d
Author: waynelwz <wytheme.go@gmail.com>
Date:   Thu Jun 15 18:56:49 2023 +0800

    wip add: job pinned & pinned_time
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit fe1f3e3 into star-whale:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants