Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): support build dataset cli from json file #2377

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Jun 20, 2023

Description

image

❯ swcli -v dataset build --json-file WebQSP.test.json --field-selector Questions
👾 verbosity: 1, log level: WARN
🚧 start to build dataset bundle...
👷 uri local/project/self/dataset/WebQSP/version/veh6xbwpldgalaik7cwywzphny3bd6nsqaipcz7w
🦋 update 1639 records into dataset
🌺 congratulation! dataset build from WebQSP.test.json has been built. You can run  swcli dataset info WebQSP/version/nxvutlja75cs

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the 0.4.10 milestone Jun 20, 2023
@tianweidut tianweidut self-assigned this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #2377 (76de6f1) into main (e4ca9e8) will increase coverage by 8.48%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2377      +/-   ##
============================================
+ Coverage     82.63%   91.11%   +8.48%     
============================================
  Files           429       98     -331     
  Lines         22948    11171   -11777     
  Branches       1347        0    -1347     
============================================
- Hits          18964    10179    -8785     
+ Misses         3376      992    -2384     
+ Partials        608        0     -608     
Flag Coverage Δ
console ?
controller ?
standalone 91.11% <100.00%> (+0.01%) ⬆️
unittests 91.11% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/dataset/model.py 98.81% <100.00%> (+<0.01%) ⬆️
client/starwhale/core/dataset/model.py 95.03% <100.00%> (+0.54%) ⬆️
client/starwhale/core/dataset/view.py 64.59% <100.00%> (+1.37%) ⬆️

... and 331 files with indirect coverage changes

@tianweidut tianweidut requested a review from anda-ren June 20, 2023 11:09
@tianweidut tianweidut marked this pull request as ready for review June 20, 2023 11:09
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit b82d5a9 into star-whale:main Jun 21, 2023
@tianweidut tianweidut deleted the feat/dataset-from-json-file branch September 5, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants