Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(console): only show current log remove log cache that viewed #2339

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Jun 9, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz requested a review from jialeicui June 9, 2023 11:02
@waynelwz waynelwz added the console 🎨 console label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #2339 (a1eff9d) into main (13c5594) will decrease coverage by 2.80%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2339      +/-   ##
============================================
- Coverage     82.55%   79.76%   -2.80%     
============================================
  Files           429        1     -428     
  Lines         22752       84   -22668     
  Branches       1327       14    -1313     
============================================
- Hits          18784       67   -18717     
+ Misses         3367       17    -3350     
+ Partials        601        0     -601     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone ?
unittests 79.76% <ø> (-11.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 428 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit dfaac24 into star-whale:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants