Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): task dev url typo #2331

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Jun 8, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Jun 8, 2023
@goldenxinxing goldenxinxing self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #2331 (4693a14) into main (436ed62) will decrease coverage by 8.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2331      +/-   ##
============================================
- Coverage     82.64%   74.57%   -8.08%     
  Complexity     2423     2423              
============================================
  Files           428      329      -99     
  Lines         22712    11591   -11121     
  Branches       1321     1307      -14     
============================================
- Hits          18771     8644   -10127     
+ Misses         3347     2351     -996     
- Partials        594      596       +2     
Flag Coverage Δ
console ?
controller 74.57% <100.00%> (-0.04%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ale/mlops/domain/task/converter/TaskConverter.java 90.00% <100.00%> (ø)

... and 102 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 2228742 into star-whale:main Jun 8, 2023
@goldenxinxing goldenxinxing deleted the fix/task_dev_url_typo branch June 30, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants