Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): ignore urllib3 InsecureRequestWarning for http requests #2301

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

tianweidut
Copy link
Member

Description

🚧 start to copy https://cloud.starwhale.cn/project/llm/model/mnist/version/6n33l65bniqduhtbm7zz6gxjjweh2ugie6izjdjy -> local/project/self/model/mnist/version/6n33l65bniqduhtbm7zz6gxjjweh2ugie6izjdjy
  ⬇ _manifest.yaml ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 1 byte ?
  ⬇ src.tar        ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 1 byte ?
  ⬇ mnist_cnn.pt   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 1 byte ?
  ⬇ packaged.swrt  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00 1 byte ?
🍵 console url of the remote bundle: https://cloud.starwhale.cn/projects/llm/models/mnist/versions/6n33l65bniqduhtbm7zz6gxjjweh2ugie6izjdjy/overview
👏 copy done.
/opt/starwhale.venv/lib/python3.8/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning: Unverified HTTPS request is being made to host 'cloud.starwhale.cn'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
  warnings.warn(
/opt/starwhale.venv/lib/python3.8/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning: Unverified HTTPS request is being made to host 'cloud.starwhale.cn'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
  warnings.warn(
/opt/starwhale.venv/lib/python3.8/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning: Unverified HTTPS request is being made to host 'cloud.starwhale.cn'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
  warnings.warn(
/opt/starwhale.venv/lib/python3.8/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning: Unverified HTTPS request is being made to host 'cloud.starwhale.cn'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
  warnings.warn(
/opt/starwhale.venv/lib/python3.8/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning: Unverified HTTPS request is being made to host 'cloud.starwhale.cn'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
  warnings.warn(

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.4.7 milestone May 31, 2023
@tianweidut tianweidut self-assigned this May 31, 2023
@tianweidut tianweidut force-pushed the chore/ssl-warning branch 2 times, most recently from f2bd4e5 to b5a473c Compare May 31, 2023 11:59
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #2301 (3396f7c) into main (6161105) will increase coverage by 8.32%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2301      +/-   ##
============================================
+ Coverage     82.68%   91.00%   +8.32%     
============================================
  Files           427       98     -329     
  Lines         22552    11003   -11549     
  Branches       1306        0    -1306     
============================================
- Hits          18646    10013    -8633     
+ Misses         3325      990    -2335     
+ Partials        581        0     -581     
Flag Coverage Δ
console ?
controller ?
standalone 91.00% <100.00%> (+0.04%) ⬆️
unittests 91.00% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/base/cloud.py 83.89% <100.00%> (+1.15%) ⬆️
client/starwhale/core/instance/view.py 66.01% <100.00%> (-0.33%) ⬇️

... and 334 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit bcdcc74 into star-whale:main Jun 1, 2023
@tianweidut tianweidut deleted the chore/ssl-warning branch September 5, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants