Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): forbid snapshot mechanism for model run in the workdir mode #2299

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented May 31, 2023

Description

❯ swcli -vvv model run -w . --dataset mnist-mini                                                                                                                                                                                                                                  
[2023-05-31 16:41:03.291385] 👾 verbosity: 3, log level: DEBUG                                                                                                                                                                                                                    
[2023-05-31 16:41:03.295316] ✈ change current dir to /home/tianwei/code/starwhale/example/mnist                                                                                                                                                                                   
[2023-05-31 16:41:03.295742] 🚀 generate jobs yaml from modules: ['mnist.evaluator:MNISTInference'] , package rootdir: /home/tianwei/code/starwhale/example/mnist                                                                                                                 
[2023-05-31 16:41:11.478755] ⏳ start to run model, handler:0 ...                                                                                                                                                                                                                 
[2023-05-31 16:41:11.481833] 🏦 runnable handlers:                                                                                                                                                                                                                                
[2023-05-31 16:41:11.482150]     *  [0]: mnist.evaluator:MNISTInference.evaluate                                                                                                                                                                                                  
[2023-05-31 16:41:11.482549]        [1]: mnist.evaluator:MNISTInference.predict                                                                                                                                                                                                   
[2023-05-31 16:41:11.483199] 💡 |INFO| start to execute step:Step: handler-mnist.evaluator:MNISTInference.predict                                                                                                                                                                 
[2023-05-31 16:41:11.484220] 💡 |INFO| start to execute task with context(step:mnist.evaluator:MNISTInference.predict, index:0/1) ...                                                                                                                                             
load mnist model, start to inference...                                                                                                                                                                                                                                           
[2023-05-31 16:41:12.676032] 💡 |INFO| start to run _starwhale_internal_run_predict function@mnist.evaluator:MNISTInference.predict-0 ...                                                                                                                                         
[2023-05-31 16:41:12.709302] 💡 |INFO| thread-140713220839504 handle scan-range: (0, 50)                                                                                                                                                                                          
[2023-05-31 16:41:12.712741] 💡 |INFO| thread-140713220839504 handle scan-range: (50, None)                                                                                                                                                                                       
[2023-05-31 16:41:12.717105] 🔈 |DEBUG| new store backend created for key: local/project/self/dataset/mnist-mini/version/mr7l2qw3skl747rk6g4iudqpkkbteahrltru7k6d.                                                                                                                
[2023-05-31 16:41:14.523393] 🔈 |DEBUG| queue details:meta fetcher(qsize:0, alive: False), row unpackers(qsize:0, alive: [False, False])                                                                                                                                          
[2023-05-31 16:41:14.524069] 💡 |INFO| mnist.evaluator:MNISTInference.predict-0 handled 100 data items for dataset ('mnist-mini',)                                                                                                                                                
[2023-05-31 16:41:14.524764] 🔈 |DEBUG| execute mnist.evaluator:MNISTInference.predict-0 exit func...                                                                                                                                                                             
[2023-05-31 16:41:14.525214] 💡 |INFO| finish step:mnist.evaluator:MNISTInference.predict, index:0/1, status:success, error:None                                                                                                                                                  
[2023-05-31 16:41:14.525796] 💡 |INFO| finish to execute step:Step: handler-mnist.evaluator:MNISTInference.predict                                                                                                                                                                
[2023-05-31 16:41:14.526972] 💡 |INFO| start to execute step:Step: handler-mnist.evaluator:MNISTInference.evaluate                                                                                                                                                                
[2023-05-31 16:41:14.527973] 💡 |INFO| start to execute task with context(step:mnist.evaluator:MNISTInference.evaluate, index:0/1) ...                                                                                                                                            
load mnist model, start to inference...                                                                                                                                                                                                                                           
[2023-05-31 16:41:14.541521] 💡 |INFO| start to run _starwhale_internal_run_evaluate function@mnist.evaluator:MNISTInference.evaluate-0 ...                                                                                                                                       
[2023-05-31 16:41:14.562486] 🔈 |DEBUG| execute mnist.evaluator:MNISTInference.evaluate-0 exit func...                                                                                                                                                                            
[2023-05-31 16:41:14.566900] 💡 |INFO| finish step:mnist.evaluator:MNISTInference.evaluate, index:0/1, status:success, error:None                                                                                                                                                 
[2023-05-31 16:41:14.568449] 💡 |INFO| finish to execute step:Step: handler-mnist.evaluator:MNISTInference.evaluate                                                                                                                                                               
[2023-05-31 16:41:14.571253] 💯 finish run, success! 

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.4.7 milestone May 31, 2023
@tianweidut tianweidut requested a review from anda-ren May 31, 2023 08:45
@tianweidut tianweidut self-assigned this May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #2299 (2d4ebed) into main (6161105) will increase coverage by 8.27%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2299      +/-   ##
============================================
+ Coverage     82.68%   90.95%   +8.27%     
============================================
  Files           427       98     -329     
  Lines         22552    10977   -11575     
  Branches       1306        0    -1306     
============================================
- Hits          18646     9984    -8662     
+ Misses         3325      993    -2332     
+ Partials        581        0     -581     
Flag Coverage Δ
console ?
controller ?
standalone 90.95% <ø> (ø)
unittests 90.95% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 329 files with indirect coverage changes

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 1b12903 into star-whale:main Jun 1, 2023
@tianweidut tianweidut deleted the chore/model-run branch September 5, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants