Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): support condarc for runtime yaml #2294

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented May 30, 2023

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.4.7 milestone May 30, 2023
@tianweidut tianweidut self-assigned this May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #2294 (cde2105) into main (db079ee) will increase coverage by 8.30%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2294      +/-   ##
============================================
+ Coverage     82.66%   90.96%   +8.30%     
============================================
  Files           427       98     -329     
  Lines         22552    10993   -11559     
  Branches       1306        0    -1306     
============================================
- Hits          18643    10000    -8643     
+ Misses         3327      993    -2334     
+ Partials        582        0     -582     
Flag Coverage Δ
console ?
controller ?
standalone 90.96% <100.00%> (+0.03%) ⬆️
unittests 90.96% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/runtime/view.py 87.62% <ø> (ø)
client/starwhale/base/type.py 100.00% <100.00%> (ø)
client/starwhale/core/runtime/model.py 93.56% <100.00%> (+0.11%) ⬆️

... and 330 files with indirect coverage changes

@tianweidut tianweidut marked this pull request as ready for review May 31, 2023 03:07
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 06eebb4 into star-whale:main Jun 1, 2023
@tianweidut tianweidut deleted the feat/support-conda-rc branch September 5, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants