Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): resolve mount path when run docker in docker #2275

Merged
merged 1 commit into from
May 25, 2023

Conversation

waynelwz
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #2275 (d1fa89a) into main (ee20acb) will decrease coverage by 2.95%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2275      +/-   ##
============================================
- Coverage     82.70%   79.76%   -2.95%     
============================================
  Files           427        1     -426     
  Lines         22534       84   -22450     
  Branches       1301       14    -1287     
============================================
- Hits          18637       67   -18570     
+ Misses         3320       17    -3303     
+ Partials        577        0     -577     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone ?
unittests 79.76% <ø> (-11.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 426 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 23c0136 into star-whale:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants