Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(console): run e2e by docker for ci #2274

Merged
merged 2 commits into from
May 24, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented May 24, 2023

  • right rendered error when mode = 2
  • add missing deps

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

* right rendered error when mode = 2
* add missing deps
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #2274 (65d30b5) into main (9b74ec9) will decrease coverage by 2.87%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2274      +/-   ##
============================================
- Coverage     82.63%   79.76%   -2.87%     
============================================
  Files           427        1     -426     
  Lines         22518       84   -22434     
  Branches       1301       14    -1287     
============================================
- Hits          18607       67   -18540     
+ Misses         3330       17    -3313     
+ Partials        581        0     -581     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone ?
unittests 79.76% <ø> (-11.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 426 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit ee20acb into star-whale:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants