Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: canceled job is not deleted #2255

Merged
merged 1 commit into from
May 17, 2023

Conversation

anda-ren
Copy link
Member

Description

Before this pull request, when a running task is set to canceled the TaskStatusMachine considered it illegal. As a result, the logic that deletes the pod wouldn't be executed. This pull request makes this status transfer legal.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added the bug 🐛 Something isn't working label May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #2255 (dcba68b) into main (69d0445) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2255      +/-   ##
============================================
+ Coverage     74.60%   74.68%   +0.08%     
- Complexity     2406     2407       +1     
============================================
  Files           328      327       -1     
  Lines         11503    11422      -81     
  Branches       1294     1280      -14     
============================================
- Hits           8582     8531      -51     
+ Misses         2341     2312      -29     
+ Partials        580      579       -1     
Flag Coverage Δ
console ?
controller 74.68% <100.00%> (+0.12%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...le/mlops/domain/task/status/TaskStatusMachine.java 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jialeicui

This comment was marked as duplicate.

@jialeicui jialeicui merged commit c251c79 into star-whale:main May 17, 2023
@anda-ren anda-ren deleted the fix_cancel_error branch May 18, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants