Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): ignore conda env by default when building model #2232

Merged
merged 1 commit into from
May 15, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #2232 (ba867aa) into main (5293c80) will increase coverage by 8.21%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2232      +/-   ##
============================================
+ Coverage     82.50%   90.72%   +8.21%     
============================================
  Files           426       98     -328     
  Lines         22400    10931   -11469     
  Branches       1288        0    -1288     
============================================
- Hits          18481     9917    -8564     
+ Misses         3344     1014    -2330     
+ Partials        575        0     -575     
Flag Coverage Δ
console ?
controller ?
standalone 90.72% <100.00%> (+0.01%) ⬆️
unittests 90.72% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/model/model.py 85.06% <ø> (ø)
client/starwhale/base/blob/store.py 100.00% <100.00%> (ø)
client/starwhale/utils/venv.py 85.27% <100.00%> (+0.07%) ⬆️

... and 330 files with indirect coverage changes

@jialeicui jialeicui requested a review from tianweidut May 15, 2023 08:46
@tianweidut tianweidut merged commit bf3565c into star-whale:main May 15, 2023
@jialeicui jialeicui deleted the mp-build-ignore branch May 15, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants