Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): fix parsing type list to tuple #2231

Merged
merged 2 commits into from
May 15, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added bug 🐛 Something isn't working datastore 🐇 e2e labels May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #2231 (0189421) into main (9569686) will increase coverage by 8.25%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2231      +/-   ##
============================================
+ Coverage     82.44%   90.70%   +8.25%     
============================================
  Files           426       98     -328     
  Lines         22398    10928   -11470     
  Branches       1288        0    -1288     
============================================
- Hits          18466     9912    -8554     
+ Misses         3357     1016    -2341     
+ Partials        575        0     -575     
Flag Coverage Δ
console ?
controller ?
standalone 90.70% <100.00%> (+0.11%) ⬆️
unittests 90.70% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/data_store.py 93.32% <100.00%> (+1.27%) ⬆️

... and 329 files with indirect coverage changes

@jialeicui jialeicui requested a review from tianweidut May 15, 2023 02:42
@tianweidut tianweidut merged commit 5293c80 into star-whale:main May 15, 2023
@jialeicui jialeicui deleted the fix-decode branch May 15, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working datastore 🐇 e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants