Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): web for job info works #2225

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented May 12, 2023

Description

  • Fix generated URI for web browser
  • Support encodeWithType and rawResult param in local fake server

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #2225 (8cda013) into main (8df82bd) will increase coverage by 15.65%.
The diff coverage is 41.30%.

@@              Coverage Diff              @@
##               main    #2225       +/-   ##
=============================================
+ Coverage     74.67%   90.33%   +15.65%     
=============================================
  Files           328       99      -229     
  Lines         11472    10979      -493     
  Branches       1288       14     -1274     
=============================================
+ Hits           8567     9918     +1351     
+ Misses         2330     1061     -1269     
+ Partials        575        0      -575     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone 90.41% <41.30%> (?)
unittests 90.33% <41.30%> (+10.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/job/view.py 76.14% <0.00%> (ø)
client/starwhale/web/project.py 100.00% <ø> (ø)
client/starwhale/api/_impl/data_store.py 91.07% <22.72%> (ø)
client/starwhale/web/data_store.py 85.36% <59.09%> (ø)
client/starwhale/base/bundle_copy.py 92.02% <100.00%> (ø)

... and 420 files with indirect coverage changes

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit ad0674c into star-whale:main May 12, 2023
@jialeicui jialeicui deleted the job-web branch May 12, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants