Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): detect shell conda bin path at first #2215

Merged
merged 1 commit into from
May 11, 2023

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added enhancement ❤️ New feature or request client 🌈 labels May 10, 2023
@tianweidut tianweidut added this to the v0.4.5 milestone May 10, 2023
@tianweidut tianweidut requested a review from anda-ren May 10, 2023 08:53
@tianweidut tianweidut self-assigned this May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #2215 (ac04d99) into main (c9eef92) will increase coverage by 8.25%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2215      +/-   ##
============================================
+ Coverage     82.21%   90.47%   +8.25%     
============================================
  Files           426       98     -328     
  Lines         22244    10805   -11439     
  Branches       1282        0    -1282     
============================================
- Hits          18289     9776    -8513     
+ Misses         3380     1029    -2351     
+ Partials        575        0     -575     
Flag Coverage Δ
console ?
controller ?
standalone 90.47% <100.00%> (+0.01%) ⬆️
unittests 90.47% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/utils/venv.py 85.09% <100.00%> (+0.31%) ⬆️

... and 330 files with indirect coverage changes

@tianweidut tianweidut requested a review from anda-ren May 11, 2023 03:03
@tianweidut tianweidut force-pushed the enhance/conda-path branch 2 times, most recently from 05b064d to 399ab9a Compare May 11, 2023 03:38
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit cfd42c6 into star-whale:main May 11, 2023
@tianweidut tianweidut deleted the enhance/conda-path branch September 5, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client 🌈 enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants