-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(job): support built-in runtime in model package #2189
Merged
tianweidut
merged 36 commits into
star-whale:main
from
goldenxinxing:feat/support_runtime_embed_in_model
May 16, 2023
Merged
feat(job): support built-in runtime in model package #2189
tianweidut
merged 36 commits into
star-whale:main
from
goldenxinxing:feat/support_runtime_embed_in_model
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jialeicui
reviewed
May 8, 2023
server/controller/src/main/java/ai/starwhale/mlops/domain/model/ModelService.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2189 +/- ##
============================================
- Coverage 82.58% 82.57% -0.01%
- Complexity 2405 2408 +3
============================================
Files 426 426
Lines 22412 22463 +51
Branches 1290 1294 +4
============================================
+ Hits 18508 18548 +40
- Misses 3327 3337 +10
- Partials 577 578 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
goldenxinxing
force-pushed
the
feat/support_runtime_embed_in_model
branch
2 times, most recently
from
May 11, 2023 08:42
33d69f1
to
86159d4
Compare
tianweidut
reviewed
May 12, 2023
goldenxinxing
force-pushed
the
feat/support_runtime_embed_in_model
branch
from
May 15, 2023 04:57
92de039
to
8d250c6
Compare
goldenxinxing
force-pushed
the
feat/support_runtime_embed_in_model
branch
2 times, most recently
from
May 15, 2023 06:31
393f7de
to
32047aa
Compare
goldenxinxing
force-pushed
the
feat/support_runtime_embed_in_model
branch
from
May 16, 2023 04:25
6e45cb6
to
bdfeda3
Compare
tianweidut
approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only one live display may be active at once)
when use Progress multiples in the same processModules
Checklist