Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(job): support built-in runtime in model package #2189

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented May 8, 2023

Description

  1. [client]copy runtime package to server in client when copy a model package with built-in runtime
  2. [client]fix the exception(Only one live display may be active at once) when use Progress multiples in the same process
  3. [server]add a column named 'built_in_runtime' for model version
  4. [console]add built-in runtime
  5. [e2e]add e2e test case
    image
    image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #2189 (c1ee992) into main (da5a69d) will decrease coverage by 0.01%.
The diff coverage is 72.05%.

@@             Coverage Diff              @@
##               main    #2189      +/-   ##
============================================
- Coverage     82.58%   82.57%   -0.01%     
- Complexity     2405     2408       +3     
============================================
  Files           426      426              
  Lines         22412    22463      +51     
  Branches       1290     1294       +4     
============================================
+ Hits          18508    18548      +40     
- Misses         3327     3337      +10     
- Partials        577      578       +1     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller 74.60% <53.65%> (-0.05%) ⬇️
standalone 90.89% <100.00%> (+0.02%) ⬆️
unittests 90.80% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...whale/mlops/api/protocol/model/ModelVersionVo.java 0.00% <0.00%> (ø)
...main/java/ai/starwhale/mlops/common/Constants.java 100.00% <ø> (ø)
.../starwhale/mlops/common/VersionAliasConverter.java 86.66% <ø> (ø)
.../mlops/domain/model/mapper/ModelVersionMapper.java 0.00% <0.00%> (ø)
...hale/mlops/domain/model/po/ModelVersionEntity.java 100.00% <ø> (ø)
.../ai/starwhale/mlops/domain/runtime/RuntimeDao.java 56.60% <0.00%> (-7.23%) ⬇️
...rwhale/mlops/domain/runtime/bo/RuntimeVersion.java 83.33% <0.00%> (-16.67%) ⬇️
...ps/domain/runtime/mapper/RuntimeVersionMapper.java 29.72% <ø> (ø)
...starwhale/mlops/domain/runtime/RuntimeService.java 74.27% <33.33%> (-0.44%) ⬇️
.../ai/starwhale/mlops/domain/model/ModelService.java 69.59% <61.53%> (+0.05%) ⬆️
... and 8 more

... and 2 files with indirect coverage changes

@goldenxinxing goldenxinxing force-pushed the feat/support_runtime_embed_in_model branch 2 times, most recently from 33d69f1 to 86159d4 Compare May 11, 2023 08:42
@goldenxinxing goldenxinxing force-pushed the feat/support_runtime_embed_in_model branch from 92de039 to 8d250c6 Compare May 15, 2023 04:57
@goldenxinxing goldenxinxing force-pushed the feat/support_runtime_embed_in_model branch 2 times, most recently from 393f7de to 32047aa Compare May 15, 2023 06:31
@goldenxinxing goldenxinxing force-pushed the feat/support_runtime_embed_in_model branch from 6e45cb6 to bdfeda3 Compare May 16, 2023 04:25
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit bc68876 into star-whale:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants