Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): deprecate URI #2185

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui changed the title deprecate URI refactor(client): deprecate URI May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #2185 (4907535) into main (c2977a9) will increase coverage by 8.56%.
The diff coverage is 93.67%.

@@            Coverage Diff             @@
##             main    #2185      +/-   ##
==========================================
+ Coverage   82.10%   90.67%   +8.56%     
==========================================
  Files           1       98      +97     
  Lines          95    10669   +10574     
  Branches       14        0      -14     
==========================================
+ Hits           78     9674    +9596     
- Misses         17      995     +978     
Flag Coverage Δ
console ?
standalone 90.67% <93.67%> (?)
unittests 90.67% <93.67%> (+8.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/base/uri/exceptions.py 100.00% <ø> (ø)
client/starwhale/core/project/model.py 66.40% <66.66%> (ø)
client/starwhale/core/dataset/store.py 93.65% <75.00%> (ø)
client/starwhale/core/job/store.py 96.87% <75.00%> (ø)
client/starwhale/base/cloud.py 82.85% <77.77%> (ø)
client/starwhale/base/uri/instance.py 94.02% <83.33%> (ø)
client/starwhale/mngt/__init__.py 63.55% <90.00%> (ø)
client/starwhale/base/bundle_copy.py 92.02% <96.87%> (ø)
...whale/api/_impl/dataset/builder/mapping_builder.py 98.51% <100.00%> (ø)
client/starwhale/api/_impl/dataset/loader.py 100.00% <100.00%> (ø)
... and 29 more

... and 60 files with indirect coverage changes

@tianweidut tianweidut merged commit 83b7508 into star-whale:main May 9, 2023
@jialeicui jialeicui deleted the deprecate-uri branch May 9, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants