Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(client): fix the expired jobs.yaml for workdir mode in the swcli model run command #2184

Merged
merged 1 commit into from
May 8, 2023

Conversation

tianweidut
Copy link
Member

Description

image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added bug 🐛 Something isn't working client 🌈 labels May 8, 2023
@tianweidut tianweidut added this to the v0.4.5 milestone May 8, 2023
@tianweidut tianweidut self-assigned this May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #2184 (9fb80e9) into main (3893da9) will increase coverage by 8.46%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2184      +/-   ##
============================================
+ Coverage     82.27%   90.74%   +8.46%     
============================================
  Files           429      100     -329     
  Lines         22245    10821   -11424     
  Branches       1276        0    -1276     
============================================
- Hits          18302     9819    -8483     
+ Misses         3371     1002    -2369     
+ Partials        572        0     -572     
Flag Coverage Δ
console ?
controller ?
standalone 90.74% <100.00%> (ø)
unittests 90.74% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/model/view.py 71.67% <ø> (ø)
client/starwhale/core/model/model.py 84.53% <100.00%> (ø)

... and 329 files with indirect coverage changes

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 40209c3 into star-whale:main May 8, 2023
@tianweidut tianweidut deleted the bug/fix-expired-job-yaml branch May 9, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working client 🌈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants