Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): PipelineHandler support predict and evaluate function interface #2183

Merged
merged 1 commit into from
May 8, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented May 6, 2023

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.4.5 milestone May 6, 2023
@tianweidut tianweidut self-assigned this May 6, 2023
@tianweidut tianweidut changed the title chore(sdk): PipelineHandler support predict and evaluate function interface chore(sdk): PipelineHandler support predict and evaluate function interface May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #2183 (c33572f) into main (5188222) will increase coverage by 8.47%.
The diff coverage is 80.43%.

❗ Current head c33572f differs from pull request most recent head 3babbc9. Consider uploading reports for the commit 3babbc9 to get more accurate results

@@             Coverage Diff              @@
##               main    #2183      +/-   ##
============================================
+ Coverage     82.26%   90.73%   +8.47%     
============================================
  Files           429      100     -329     
  Lines         22303    10836   -11467     
  Branches       1276        0    -1276     
============================================
- Hits          18347     9832    -8515     
+ Misses         3384     1004    -2380     
+ Partials        572        0     -572     
Flag Coverage Δ
console ?
controller ?
standalone 90.73% <80.43%> (+0.06%) ⬆️
unittests 90.73% <80.43%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/job/view.py 76.02% <0.00%> (-0.13%) ⬇️
client/starwhale/base/scheduler/task.py 88.42% <80.00%> (ø)
client/starwhale/api/_impl/evaluation.py 91.41% <83.33%> (-0.48%) ⬇️
client/starwhale/api/_impl/job.py 99.13% <100.00%> (ø)
client/starwhale/utils/progress.py 100.00% <100.00%> (ø)

... and 359 files with indirect coverage changes

@tianweidut tianweidut force-pushed the chore/unify-name branch 2 times, most recently from 5143986 to c67a8b2 Compare May 6, 2023 12:00
goldenxinxing
goldenxinxing previously approved these changes May 8, 2023
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 549f202 into star-whale:main May 8, 2023
@tianweidut tianweidut deleted the chore/unify-name branch May 9, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants