Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(console): tooltip/datepicker/locales and new extend mode #2179

Merged
merged 15 commits into from
May 6, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented May 5, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz requested a review from jialeicui May 5, 2023 05:43
@waynelwz waynelwz added chore 🛎️ some tiny change console 🎨 console labels May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #2179 (28f014f) into main (94eeff7) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2179      +/-   ##
============================================
- Coverage     82.22%   82.10%   -0.12%     
============================================
  Files           428        1     -427     
  Lines         22166       95   -22071     
  Branches       1274       14    -1260     
============================================
- Hits          18226       78   -18148     
+ Misses         3371       17    -3354     
+ Partials        569        0     -569     
Flag Coverage Δ
console 82.10% <ø> (ø)
controller ?
standalone ?
unittests 82.10% <ø> (-8.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 427 files with indirect coverage changes

@waynelwz waynelwz changed the title update(console): tooltip/datepicker and locales update(console): tooltip/datepicker/locales and new extend mode May 6, 2023
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit a79652d into star-whale:main May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change console 🎨 console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants