Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): tune client logger/console.print #2158

Merged
merged 1 commit into from
May 5, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Apr 27, 2023

Description

  • previous log
    image

  • new log
    asciicast

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.4.4 milestone Apr 27, 2023
@tianweidut tianweidut self-assigned this Apr 27, 2023
@tianweidut tianweidut force-pushed the enhance/model-log branch 3 times, most recently from 9af1138 to ddf8383 Compare April 27, 2023 13:32
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #2158 (a33dbb1) into main (94eeff7) will increase coverage by 8.39%.
The diff coverage is 87.66%.

@@             Coverage Diff              @@
##               main    #2158      +/-   ##
============================================
+ Coverage     82.22%   90.61%   +8.39%     
============================================
  Files           428      100     -328     
  Lines         22166    10767   -11399     
  Branches       1274        0    -1274     
============================================
- Hits          18226     9757    -8469     
+ Misses         3371     1010    -2361     
+ Partials        569        0     -569     
Flag Coverage Δ
console ?
controller ?
standalone 90.61% <87.66%> (-0.03%) ⬇️
unittests 90.61% <87.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/job.py 99.06% <ø> (-0.02%) ⬇️
client/starwhale/base/bundle.py 89.05% <ø> (-0.46%) ⬇️
client/starwhale/base/bundle_copy.py 93.33% <ø> (ø)
client/starwhale/core/dataset/copy.py 94.61% <ø> (ø)
client/starwhale/core/job/view.py 76.02% <ø> (-0.25%) ⬇️
client/starwhale/utils/load.py 90.24% <33.33%> (-0.67%) ⬇️
client/starwhale/core/model/model.py 84.26% <50.00%> (+0.05%) ⬆️
client/starwhale/api/_impl/evaluation.py 91.84% <55.55%> (-1.21%) ⬇️
client/starwhale/utils/http.py 86.11% <66.66%> (-0.38%) ⬇️
client/starwhale/base/scheduler/task.py 88.42% <75.00%> (ø)
... and 20 more

... and 329 files with indirect coverage changes

@tianweidut tianweidut force-pushed the enhance/model-log branch 3 times, most recently from f8dd61d to 92fd45e Compare April 28, 2023 06:41
@tianweidut tianweidut modified the milestones: v0.4.4, v0.4.5 May 4, 2023
- use rich.console as the global default logger
- remove useless log file for PipelineHandler
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 9f0c7a2 into star-whale:main May 5, 2023
@tianweidut tianweidut deleted the enhance/model-log branch May 9, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants