Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): missing time format & popover ui #2096

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

waynelwz
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz requested a review from jialeicui April 14, 2023 02:26
@waynelwz waynelwz assigned jialeicui and unassigned jialeicui Apr 14, 2023
@waynelwz waynelwz added enhancement ❤️ New feature or request console 🎨 console labels Apr 14, 2023
jialeicui
jialeicui previously approved these changes Apr 14, 2023
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #2096 (1a5a56e) into main (1a8eec6) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2096      +/-   ##
============================================
+ Coverage     82.06%   82.10%   +0.03%     
============================================
  Files           427        1     -426     
  Lines         22162       95   -22067     
  Branches       1248       14    -1234     
============================================
- Hits          18188       78   -18110     
+ Misses         3420       17    -3403     
+ Partials        554        0     -554     
Flag Coverage Δ
console 82.10% <ø> (ø)
controller ?
standalone ?
unittests 82.10% <ø> (-8.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 426 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui self-requested a review April 14, 2023 03:11
@jialeicui jialeicui merged commit 3e9a7c6 into star-whale:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console 🎨 console enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants