Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): optimize upgrade/cancel upgrading api and fix some bugs #2076

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Apr 12, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu self-assigned this Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #2076 (a1245fb) into main (aa7c1b0) will decrease coverage by 8.17%.
The diff coverage is 41.93%.

@@             Coverage Diff              @@
##               main    #2076      +/-   ##
============================================
- Coverage     82.18%   74.02%   -8.17%     
- Complexity     2332     2334       +2     
============================================
  Files           425      326      -99     
  Lines         21963    11129   -10834     
  Branches       1244     1232      -12     
============================================
- Hits          18051     8238    -9813     
+ Misses         3361     2338    -1023     
- Partials        551      553       +2     
Flag Coverage Δ
console ?
controller 74.02% <41.93%> (-0.08%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/ai/starwhale/mlops/api/SystemController.java 90.00% <0.00%> (-10.00%) ⬇️
...i/starwhale/mlops/domain/system/SystemService.java 0.00% <0.00%> (ø)
...hale/mlops/domain/upgrade/step/BackupDatabase.java 82.75% <ø> (+7.00%) ⬆️
.../starwhale/mlops/domain/upgrade/step/StepTask.java 72.41% <0.00%> (-18.90%) ⬇️
.../mlops/domain/upgrade/step/UpgradeStepManager.java 78.57% <40.00%> (-21.43%) ⬇️
...hale/mlops/domain/upgrade/step/UpdateK8sImage.java 69.56% <50.00%> (-8.22%) ⬇️
...starwhale/mlops/domain/upgrade/UpgradeService.java 81.48% <80.00%> (+1.73%) ⬆️

... and 101 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dreamlandliu dreamlandliu removed the e2e label Apr 12, 2023
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 0154e5f into star-whale:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants