Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example(GraphQuestions): add graph_questions_testing dataset #2075

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

anda-ren
Copy link
Member

Description

  1. add graph_questions_testing dataset
  2. add dataset util function from_dict

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren self-assigned this Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #2075 (33e8a3e) into main (be7fb58) will increase coverage by 8.42%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2075      +/-   ##
============================================
+ Coverage     82.13%   90.55%   +8.42%     
============================================
  Files           424       98     -326     
  Lines         21859    10772   -11087     
  Branches       1230        0    -1230     
============================================
- Hits          17954     9755    -8199     
+ Misses         3353     1017    -2336     
+ Partials        552        0     -552     
Flag Coverage Δ
controller ?
standalone 90.55% <100.00%> (+0.04%) ⬆️
unittests 90.55% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/dataset/model.py 98.64% <100.00%> (+0.05%) ⬆️

... and 327 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 3676f39 into star-whale:main Apr 13, 2023
@anda-ren anda-ren deleted the gqa_ds branch April 13, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants