Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(console): support mixed type column #2072

Merged
merged 19 commits into from
Apr 12, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Apr 11, 2023

Description

add datastore model for schema decode
refactor evaluation list / compare / panel / dataset with mixed type
add core unittest case for datastore model

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz changed the title refactor(console): support mixed type column wip refactor(console): support mixed type column Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #2072 (9f5235a) into main (be7fb58) will decrease coverage by 0.04%.
The diff coverage is 82.10%.

@@             Coverage Diff              @@
##               main    #2072      +/-   ##
============================================
- Coverage     82.13%   82.10%   -0.04%     
============================================
  Files           424        1     -423     
  Lines         21859       95   -21764     
  Branches       1230       14    -1216     
============================================
- Hits          17954       78   -17876     
+ Misses         3353       17    -3336     
+ Partials        552        0     -552     
Flag Coverage Δ
console 82.10% <82.10%> (?)
controller ?
standalone ?
unittests 82.10% <82.10%> (-8.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ole/packages/starwhale-core/src/datastore/model.ts 82.10% <82.10%> (ø)

... and 424 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@waynelwz waynelwz changed the title wip refactor(console): support mixed type column refactor(console): support mixed type column Apr 12, 2023
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 5f65c1b into star-whale:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants