Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): compress data store table file #2058

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Apr 7, 2023

Description

Compress data store table file

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #2058 (9ea4297) into main (3d1da21) will increase coverage by 8.54%.
The diff coverage is 94.31%.

@@             Coverage Diff              @@
##               main    #2058      +/-   ##
============================================
+ Coverage     82.22%   90.77%   +8.54%     
============================================
  Files           411       98     -313     
  Lines         21409    10668   -10741     
  Branches       1219        0    -1219     
============================================
- Hits          17604     9684    -7920     
+ Misses         3258      984    -2274     
+ Partials        547        0     -547     
Flag Coverage Δ
controller ?
standalone 90.77% <94.31%> (+<0.01%) ⬆️
unittests 90.77% <94.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/data_store.py 94.34% <94.31%> (-0.22%) ⬇️

... and 313 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 0f27df1 into star-whale:main Apr 8, 2023
@jialeicui jialeicui deleted the datastore-compression branch April 8, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants