Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): change shared type to boolean #2044

Merged
merged 6 commits into from
Apr 13, 2023

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Mar 30, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu self-assigned this Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #2044 (c32f31c) into main (c76bffe) will decrease coverage by 8.35%.
The diff coverage is 100.00%.

❗ Current head c32f31c differs from pull request most recent head 540f1c7. Consider uploading reports for the commit 540f1c7 to get more accurate results

@@             Coverage Diff              @@
##               main    #2044      +/-   ##
============================================
- Coverage     82.04%   73.69%   -8.35%     
+ Complexity     2335     2251      -84     
============================================
  Files           427      313     -114     
  Lines         22125    10790   -11335     
  Branches       1248     1217      -31     
============================================
- Hits          18152     7952   -10200     
+ Misses         3418     2291    -1127     
+ Partials        555      547       -8     
Flag Coverage Δ
console ?
controller 73.69% <100.00%> (-0.29%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/ai/starwhale/mlops/api/DatasetController.java 81.56% <ø> (ø)
...java/ai/starwhale/mlops/api/RuntimeController.java 92.68% <ø> (ø)
...ps/domain/dataset/mapper/DatasetVersionMapper.java 0.00% <ø> (ø)
.../mlops/domain/dataset/po/DatasetVersionEntity.java 100.00% <ø> (ø)
...ps/domain/runtime/mapper/RuntimeVersionMapper.java 29.72% <ø> (ø)
.../mlops/domain/runtime/po/RuntimeVersionEntity.java 100.00% <ø> (ø)
...starwhale/mlops/domain/dataset/DatasetService.java 86.87% <100.00%> (-0.25%) ⬇️
...n/dataset/converter/DatasetVersionVoConverter.java 87.50% <100.00%> (ø)
...starwhale/mlops/domain/runtime/RuntimeService.java 72.25% <100.00%> (-2.45%) ⬇️
...ain/runtime/converter/RuntimeVersionConverter.java 100.00% <100.00%> (ø)

... and 144 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

goldenxinxing
goldenxinxing previously approved these changes Apr 13, 2023
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 0d0b7eb into star-whale:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants