Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataset):add more info into dataset summary #2029

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.4.2 milestone Mar 29, 2023
@tianweidut tianweidut self-assigned this Mar 29, 2023
@tianweidut tianweidut force-pushed the feat/summary-dataset branch 2 times, most recently from 157d032 to 331330d Compare March 29, 2023 07:41
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #2029 (ddb4539) into main (aef24af) will increase coverage by 8.54%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##               main    #2029      +/-   ##
============================================
+ Coverage     81.92%   90.47%   +8.54%     
============================================
  Files           411       98     -313     
  Lines         21307    10603   -10704     
  Branches       1214        0    -1214     
============================================
- Hits          17456     9593    -7863     
+ Misses         3302     1010    -2292     
+ Partials        549        0     -549     
Flag Coverage Δ
controller ?
standalone 90.47% <71.42%> (-0.01%) ⬇️
unittests 90.47% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/dataset/model.py 85.27% <ø> (ø)
client/starwhale/core/project/view.py 56.75% <0.00%> (ø)
client/starwhale/api/_impl/dataset/model.py 97.92% <71.42%> (-0.24%) ⬇️
client/starwhale/base/cloud.py 83.33% <100.00%> (ø)
client/starwhale/core/dataset/type.py 93.94% <100.00%> (-0.02%) ⬇️

... and 313 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut marked this pull request as draft March 29, 2023 11:32
@tianweidut tianweidut force-pushed the feat/summary-dataset branch 2 times, most recently from 623ccdd to 906d32c Compare March 30, 2023 03:48
@tianweidut tianweidut marked this pull request as ready for review March 30, 2023 03:50
- replace dataset_byte_size with blobs_byte_size
- add increased_blobs_byte_size into DatasetSummary
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit ebd0341 into star-whale:main Mar 30, 2023
@tianweidut tianweidut deleted the feat/summary-dataset branch April 14, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants