Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): make the internal options hidden in the --help output #2027

Merged

Conversation

tianweidut
Copy link
Member

Description

  • hidden some options in the --help output, but they can work, and reduce learning costs for the users.

image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added doc 📄 Improvements or additions to documentation chore 🛎️ some tiny change client 🌈 labels Mar 29, 2023
@tianweidut tianweidut added this to the v0.4.2 milestone Mar 29, 2023
@tianweidut tianweidut self-assigned this Mar 29, 2023
@tianweidut
Copy link
Member Author

cc @xuchuan

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #2027 (3276ffd) into main (aecf5bc) will increase coverage by 8.46%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2027      +/-   ##
============================================
+ Coverage     82.10%   90.57%   +8.46%     
============================================
  Files           412       99     -313     
  Lines         21610    10902   -10708     
  Branches       1214        0    -1214     
============================================
- Hits          17742     9874    -7868     
+ Misses         3320     1028    -2292     
+ Partials        548        0     -548     
Flag Coverage Δ
controller ?
standalone 90.57% <ø> (ø)
unittests 90.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 313 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

goldenxinxing
goldenxinxing previously approved these changes Mar 30, 2023
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing self-requested a review March 30, 2023 02:22
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 20a7970 into star-whale:main Mar 30, 2023
@tianweidut tianweidut deleted the chore/hidden-internal-options branch April 14, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change client 🌈 doc 📄 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants