Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): datastore query and scan api support revision #2021

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Mar 27, 2023

Description

  • Use timestamp ms as revision for scan and query
  • Ignore the entry with the key only which does not match the revision when scan

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft March 27, 2023 11:20
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #2021 (13bad34) into main (d346966) will decrease coverage by 8.56%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main    #2021      +/-   ##
============================================
- Coverage     82.14%   73.59%   -8.56%     
- Complexity     2218     2224       +6     
============================================
  Files           409      310      -99     
  Lines         21574    10693   -10881     
  Branches       1207     1210       +3     
============================================
- Hits          17723     7870    -9853     
+ Misses         3303     2276    -1027     
+ Partials        548      547       -1     
Flag Coverage Δ
controller 73.59% <80.00%> (+0.04%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/ai/starwhale/mlops/api/DataStoreController.java 85.40% <66.66%> (-0.31%) ⬇️
...n/java/ai/starwhale/mlops/datastore/DataStore.java 86.29% <80.00%> (+1.07%) ⬆️
...tarwhale/mlops/datastore/impl/MemoryTableImpl.java 87.13% <85.71%> (+0.15%) ⬆️

... and 99 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui force-pushed the server-revision branch 5 times, most recently from b155ee9 to bb128d0 Compare March 28, 2023 07:57
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 9784e64 into star-whale:main Mar 29, 2023
@jialeicui jialeicui deleted the server-revision branch April 8, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants