Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dataset): remove dataset origin field #2020

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.4.2 milestone Mar 27, 2023
@tianweidut tianweidut self-assigned this Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #2020 (6b0adac) into main (aef24af) will increase coverage by 8.53%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2020      +/-   ##
============================================
+ Coverage     81.92%   90.46%   +8.53%     
============================================
  Files           411       98     -313     
  Lines         21307    10591   -10716     
  Branches       1214        0    -1214     
============================================
- Hits          17456     9581    -7875     
+ Misses         3302     1010    -2292     
+ Partials        549        0     -549     
Flag Coverage Δ
controller ?
standalone 90.46% <100.00%> (-0.02%) ⬇️
unittests 90.46% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/base/type.py 100.00% <ø> (ø)
client/starwhale/core/dataset/tabular.py 97.23% <100.00%> (-0.38%) ⬇️

... and 313 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut marked this pull request as ready for review March 30, 2023 03:35
@tianweidut
Copy link
Member Author

cc @waynelwz

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 9adab60 into star-whale:main Mar 30, 2023
@tianweidut tianweidut deleted the chore/remove-dataset-origin branch April 14, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants