Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): add ui assets to pkg data #2012

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

jialeicui
Copy link
Contributor

Description

wheel

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #2012 (aae9fbb) into main (1814201) will increase coverage by 8.53%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2012      +/-   ##
============================================
+ Coverage     82.29%   90.83%   +8.53%     
============================================
  Files           409       99     -310     
  Lines         21623    10938   -10685     
  Branches       1207        0    -1207     
============================================
- Hits          17795     9935    -7860     
+ Misses         3281     1003    -2278     
+ Partials        547        0     -547     
Flag Coverage Δ
controller ?
standalone 90.83% <ø> (+<0.01%) ⬆️
unittests 90.83% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 312 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit a2e57e7 into star-whale:main Mar 25, 2023
@jialeicui jialeicui deleted the release-wheel branch March 25, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants