Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(example): fix examples(nmt/pfp) evaluation_store typo #2010

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Mar 24, 2023

Description

img_v2_fe558522-d170-4f24-97f9-f67bd849ddeg

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added bug 🐛 Something isn't working example 🚕 labels Mar 24, 2023
@tianweidut tianweidut added this to the v0.4.2 milestone Mar 24, 2023
@tianweidut tianweidut self-assigned this Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #2010 (694fb18) into main (35bd7cc) will increase coverage by 8.53%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2010      +/-   ##
============================================
+ Coverage     82.29%   90.83%   +8.53%     
============================================
  Files           409       99     -310     
  Lines         21624    10938   -10686     
  Branches       1207        0    -1207     
============================================
- Hits          17796     9935    -7861     
+ Misses         3280     1003    -2277     
+ Partials        548        0     -548     
Flag Coverage Δ
controller ?
standalone 90.83% <ø> (ø)
unittests 90.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 310 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 4773e9d into star-whale:main Mar 24, 2023
@tianweidut tianweidut deleted the fix/evaluation branch April 14, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working example 🚕
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants